Re: [PATCH v3 2/4] x86/boot: Add acpitb.c to parse acpi tables

[Chao Fan]

On Thu, Jul 19, 2018 at 05:22:35PM +0200, Thomas Gleixner wrote:
>On Tue, 17 Jul 2018, Chao Fan wrote:
>> +
>> +/* Search efi table for rsdp table. */
>> +static bool efi_get_rsdp_addr(acpi_physical_address *rsdp_addr)
>> +{
>> +	efi_system_table_t *systab;
>> +	bool find_rsdp = false;
>> +	bool acpi_20 = false;
>> +	bool efi_64 = false;
>> +	void *config_tables;
>> +	struct efi_info *e;
>> +	char *sig;
>> +	int size;
>> +	int i;
>> +
>> +#ifndef CONFIG_EFI
>> +	return false;
>> +#endif
>
>Please no. Wrap the whole function into CONFIG_EFI annd have a stub for the
>non EFI case returning false.

Yes, you are right. Will change it in the next version.

Thanks,
Chao Fan

>
>Thanks,
>
>	tglx
>
>