Re: [PATCH 2/6] drivers/md/raid5: Do not disable irq on release_inactive_stripe_list() call

From: Sebastian Andrzej Siewior
Date: Fri Jul 20 2018 - 04:29:31 EST


On 2018-07-03 22:01:37 [+0200], To linux-kernel@xxxxxxxxxxxxxxx wrote:
> From: Anna-Maria Gleixner <anna-maria@xxxxxxxxxxxxx>
>
> There is no need to invoke release_inactive_stripe_list() with interrupts
> disabled. All call sites, except raid5_release_stripe(), unlock
> ->device_lock and enable interrupts before invoking the function.
>
> Make it consistent.

Shaohua, I've seen that you already applied 1/6. Could you also please
apply this one? This is the only remaining raid5 patch :)

> Cc: Shaohua Li <shli@xxxxxxxxxx>
> Cc: linux-raid@xxxxxxxxxxxxxxx
> Acked-by: Peter Zijlstra (Intel) <peterz@xxxxxxxxxxxxx>
> Signed-off-by: Anna-Maria Gleixner <anna-maria@xxxxxxxxxxxxx>
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@xxxxxxxxxxxxx>
> ---
> drivers/md/raid5.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/md/raid5.c b/drivers/md/raid5.c
> index e933bff9459e..ca1dd0cb04c5 100644
> --- a/drivers/md/raid5.c
> +++ b/drivers/md/raid5.c
> @@ -414,9 +414,8 @@ void raid5_release_stripe(struct stripe_head *sh)
> INIT_LIST_HEAD(&list);
> hash = sh->hash_lock_index;
> do_release_stripe(conf, sh, &list);
> - spin_unlock(&conf->device_lock);
> + spin_unlock_irqrestore(&conf->device_lock, flags);
> release_inactive_stripe_list(conf, &list, hash);
> - local_irq_restore(flags);
> }
> }
>

Sebastian