Re: [PATCH 4/4] perf tools: Move syscall_64.tbl check into check-headers.sh

From: Jiri Olsa
Date: Fri Jul 20 2018 - 11:14:15 EST


On Fri, Jul 20, 2018 at 12:03:54PM -0300, Arnaldo Carvalho de Melo wrote:
> Em Fri, Jul 20, 2018 at 01:00:36PM +0200, Jiri Olsa escreveu:
> > Probably leftover from the time we introducd the check-headers.sh script.
>
> So, with your patch:
>
> [acme@jouet perf]$ git diff
> diff --git a/arch/x86/entry/syscalls/syscall_64.tbl b/arch/x86/entry/syscalls/syscall_64.tbl
> index f0b1709a5ffb..cfc1b0949bb1 100644
> --- a/arch/x86/entry/syscalls/syscall_64.tbl
> +++ b/arch/x86/entry/syscalls/syscall_64.tbl
> @@ -343,6 +343,7 @@
> 332 common statx __x64_sys_statx
> 333 common io_pgetevents __x64_sys_io_pgetevents
> 334 common rseq __x64_sys_rseq
> +335 common krava __x64_sys_krava
>
> #
> # x32-specific system call numbers start at 512 to avoid cache impact
> [acme@jouet perf]$
>
>
> It doesn't warn about that new cool syscall, without your patch:
>
> Warning: Kernel ABI header at 'tools/perf/arch/x86/entry/syscalls/syscall_64.tbl' differs from latest version at 'arch/x86/entry/syscalls/syscall_64.tbl'
>
> Can you check this?

hum, did you have the previous patch applied?
without it it displays misleading output

will check

jirka