Re: [PATCH 2/3] tty: Make constants to be enums instead of #define in goldfish.c

From: Greg KH
Date: Sat Jul 21 2018 - 03:45:26 EST

Next message: Mr Fawaz Al Saleh: "Hello"
Previous message: Greg KH: "Re: [PATCH 1/3] tty: Address checkpatch warnings in goldfish.c"
In reply to: rkir: "[PATCH 2/3] tty: Make constants to be enums instead of #define in goldfish.c"
Next in thread: rkir: "[PATCH 3/3] tty: Mark goldfish_tty_line_count as const"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On Tue, Jul 17, 2018 at 05:14:54PM -0700, rkir@xxxxxxxxxx wrote:
> From: Roman Kiryanov <rkir@xxxxxxxxxx>
>
> enums produce better compilation errors than defines.

Yes, if you name the enum. But you didn't do that here, so this patch
really does not do anything to cause any "protection" at all :(

Please fix this up and resend.

thanks,

greg k-h

Next message: Mr Fawaz Al Saleh: "Hello"
Previous message: Greg KH: "Re: [PATCH 1/3] tty: Address checkpatch warnings in goldfish.c"
In reply to: rkir: "[PATCH 2/3] tty: Make constants to be enums instead of #define in goldfish.c"
Next in thread: rkir: "[PATCH 3/3] tty: Mark goldfish_tty_line_count as const"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]