Re: [PATCH v4 13/35] mtd: rawnand: marvell: convert driver to nand_scan()

From: Boris Brezillon
Date: Sat Jul 21 2018 - 12:58:03 EST


On Fri, 20 Jul 2018 17:15:05 +0200
Miquel Raynal <miquel.raynal@xxxxxxxxxxx> wrote:

>
> - ret = nand_scan_tail(mtd);
> + chip->controller->ops = &marvell_nand_controller_ops;

Assigning ->ops to &marvell_nand_controller_ops should be done only
once in the probe function (here [1]). With that fixed, you can add

Reviewed-by: Boris Brezillon <boris.brezillon@xxxxxxxxxxx>

> + ret = nand_scan(mtd, marvell_nand->nsels);
> if (ret) {
> - dev_err(dev, "nand_scan_tail failed: %d\n", ret);
> + dev_err(dev, "could not scan the nand chip\n");
> return ret;
> }
>