Re: [PATCH v2 bpf-next] bpfilter: Fix mismatch in function argument types
From: David Miller
Date: Sat Jul 21 2018 - 19:21:55 EST
From: Daniel Borkmann <daniel@xxxxxxxxxxxxx>
Date: Thu, 19 Jul 2018 17:51:41 +0200
> On 07/19/2018 05:48 PM, Martin KaFai Lau wrote:
>> On Thu, Jul 19, 2018 at 03:56:59PM +0800, YueHaibing wrote:
>>> Fix following warning:
>>> net/ipv4/bpfilter/sockopt.c:28:5: error: symbol 'bpfilter_ip_set_sockopt' redeclared with different type
>>> net/ipv4/bpfilter/sockopt.c:34:5: error: symbol 'bpfilter_ip_get_sockopt' redeclared with different type
>>>
>>> Signed-off-by: YueHaibing <yuehaibing@xxxxxxxxxx>
>> LGTM. Missing a Fixes tag though.
>>
>> Fixes: d2ba09c17a06 ("net: add skeleton of bpfilter kernel module")
>> Acked-by: Martin KaFai Lau <kafai@xxxxxx>
>
> (Should go to -net tree.)
>
> Acked-by: Daniel Borkmann <daniel@xxxxxxxxxxxxx>
Applied.