Re: [PATCH] arch/h8300: eliminate kgbd.c warning

From: Yoshinori Sato
Date: Sun Jul 22 2018 - 09:33:40 EST


On Fri, 20 Jul 2018 11:36:06 +0900,
Randy Dunlap wrote:
>
> From: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
>
> Drop the "const" qualifier from arch_kgdb_ops to eliminate the gcc
> warning (gcc version is 8.1.0).
>
> arch/h8300/kernel/kgdb.c:132:24: error: conflicting type qualifiers for 'arch_kgdb_ops'
> const struct kgdb_arch arch_kgdb_ops = {
> In file included from ../arch/h8300/kernel/kgdb.c:12:
> ../include/linux/kgdb.h:284:26: note: previous declaration of 'arch_kgdb_ops' was here
> extern struct kgdb_arch arch_kgdb_ops;
>
> Signed-off-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
> Cc: Yoshinori Sato <ysato@xxxxxxxxxxxxxxxxxxxx>
> Cc: uclinux-h8-devel@xxxxxxxxxxxxxxxxxxxx
> ---
> arch/h8300/kernel/kgdb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- linux-next-20180717.orig/arch/h8300/kernel/kgdb.c
> +++ linux-next-20180717/arch/h8300/kernel/kgdb.c
> @@ -129,7 +129,7 @@ void kgdb_arch_exit(void)
> /* Nothing to do */
> }
>
> -const struct kgdb_arch arch_kgdb_ops = {
> +struct kgdb_arch arch_kgdb_ops = {
> /* Breakpoint instruction: trapa #2 */
> .gdb_bpt_instr = { 0x57, 0x20 },
> };
>
>

Applied to h8300-next.
Thanks.

--
Yosinori Sato