Re: [PATCH v2 1/6] ext4: sysfs: print ext4_super_block fields as little-endian
From: Theodore Y. Ts'o
Date: Sun Jul 22 2018 - 13:23:31 EST
On Wed, Jul 11, 2018 at 11:14:09AM +0200, Arnd Bergmann wrote:
> While working on extended rand for last_error/first_error timestamps,
> I noticed that the endianess is wrong, we access the little-endian
> fields in struct ext4_super_block as native-endian when we print them.
>
> This adds a special case in ext4_attr_show() and ext4_attr_store()
> to byteswap the superblock fields if needed.
>
> In older kernels, this code was part of super.c, it got moved to sysfs.c
> in linux-4.4.
>
> Cc: stable@xxxxxxxxxxxxxxx
> Fixes: 52c198c6820f ("ext4: add sysfs entry showing whether the fs contains errors")
> Reviewed-by: Andreas Dilger <adilger@xxxxxxxxx>
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
Applied, thanks.
- Ted