Re: [PATCH] x86: czc-tablet: add driver that fixes the buttons on CZC P10T tablet

From: kbuild test robot
Date: Sun Jul 22 2018 - 14:37:32 EST


Hi Lubomir,

I love your patch! Yet something to improve:

[auto build test ERROR on sof-driver-fuweitax/master]
[also build test ERROR on v4.18-rc5 next-20180720]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url: https://github.com/0day-ci/linux/commits/Lubomir-Rintel/x86-czc-tablet-add-driver-that-fixes-the-buttons-on-CZC-P10T-tablet/20180722-064855
base: https://github.com/fuweitax/linux master
config: x86_64-randconfig-s5-07222103 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-16) 7.3.0
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64

All errors (new ones prefixed by >>):

drivers/platform/x86/czc-tablet.c: In function 'czc_tablet_init':
>> drivers/platform/x86/czc-tablet.c:64:2: error: implicit declaration of function 'outb' [-Werror=implicit-function-declaration]
outb(CZC_EC_ANDROID_KEYS, CZC_EC_EXTRA_PORT);
^~~~
Cyclomatic Complexity 1 drivers/platform/x86/czc-tablet.c:czc_tablet_exit
Cyclomatic Complexity 3 drivers/platform/x86/czc-tablet.c:czc_tablet_init
Cyclomatic Complexity 1 drivers/platform/x86/czc-tablet.c:_GLOBAL__sub_D_65535_0_czc_tablet.c
Cyclomatic Complexity 1 drivers/platform/x86/czc-tablet.c:_GLOBAL__sub_I_65535_1_czc_tablet.c
cc1: some warnings being treated as errors

vim +/outb +64 drivers/platform/x86/czc-tablet.c

58
59 static int __init czc_tablet_init(void)
60 {
61 if (!force && !dmi_check_system(czc_tablet_table))
62 return -ENODEV;
63
> 64 outb(CZC_EC_ANDROID_KEYS, CZC_EC_EXTRA_PORT);
65
66 return 0;
67 }
68

---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation

Attachment: .config.gz
Description: application/gzip