Re: [PATCH 05/11] touchscreen: elants: Use octal permissions

From: Greg Kroah-Hartman
Date: Mon Jul 23 2018 - 09:32:07 EST


On Mon, Jul 23, 2018 at 06:49:20PM +0530, dev-harsh1998 wrote:
> WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'.
> +static DEVICE_ATTR(iap_mode, S_IRUGO, show_iap_mode, NULL);
>
> WARNING: Symbolic permissions 'S_IWUSR' are not preferred. Consider using octal permissions '0200'.
> +static DEVICE_ATTR(update_fw, S_IWUSR, NULL, write_update_fw)
>
> WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'.
> + .dattr = __ATTR(_field, S_IRUGO, \
>
> Signed-off-by: Harshit Jain <harshitjain6751@xxxxxxxxx>

This name doesn't match up with the From: line above :(

Please fix up and try again.

thanks,

greg k-h