Re: [PATCH/RFT 2/6] i2c: imx: use open drain for recovery GPIO

From: Wolfram Sang
Date: Tue Jul 24 2018 - 03:28:04 EST


Hi Lucas,

> I don't think this matters on any of the i.MX platforms, as the GPIO
> pin configuration (including open-drain) is only taken from the DT
> pinctrl, with the GPIO driver not being able to change any of those. On
> the flipside this results in a near zero probability of regressions.
> ;)

I see. Thanks for the heads up.

> As this is obviously right even if it doesn't have any effect on
> current software:
>
> Reviewed-by: Lucas Stach <l.stach@xxxxxxxxxxxxxx>

Thanks. Yeah, let's fix it. It might serve as an example for other
people.

Attachment: signature.asc
Description: PGP signature