Re: [PATCH 2/2] pinctrl/amd: use byte access to clear irq/wake status bits
From: Daniel Drake
Date: Tue Jul 24 2018 - 08:29:08 EST
On Fri, Jul 20, 2018 at 6:38 PM, Daniel Kurtz <djkurtz@xxxxxxxxxxxx> wrote:
> Sounds reasonable. How about:
> - /* Clear interrupt.
> - * We must read the pin register again, in case the
> - * value was changed while executing
> - * generic_handle_irq() above.
> + /*
> + * Write-1-to-clear irq/wake status bits in MSByte.
> + * All other bits in this byte are read-only.
> + * This avoids modifying the lower 24-bits
> because they may have
> + * changed while executing generic_handle_irq() above.
That looks good. Thanks