Re: [PATCH v2] ACPI: bus.c: Let acpi_device_get_match_data() return DT compatibility data

From: Nikolaus Voss
Date: Tue Jul 24 2018 - 09:32:01 EST


On Mon, 9 Jul 2018, Rafael J. Wysocki wrote:
On Wednesday, July 4, 2018 4:40:34 PM CEST Andy Shevchenko wrote:
On Tue, Jul 3, 2018 at 9:09 AM, Nikolaus Voss <nv@xxxxxxx> wrote:
When using ACPI with ACPI_DT_NAMESPACE_HID/ PRP0001 HID and referring to
of_device_id table "compatible" strings in DSD, a pointer to the
corresponding DT table entry should be returned instead of a null
pointer. An acpi_device_id match still takes precedence.


Reviewed-by: Andy Shevchenko <andy.shevchenko@xxxxxxxxx>

with a caveat that this is only an improvement for a _temporary_
PRP0001 users like I2C or SPI slave devices.
Please, don't consider this change as a valid point to (ab)use PRP0001
in a cases where devices are not "hotpluggable".

v2: improve readability (as suggested by Andy Shevchenko)

Signed-off-by: Nikolaus Voss <nikolaus.voss@xxxxxxxxxxxxxxxxxxxxx>

Nikolaus, please resend the v2 with the Andy's tag to linux-acpi@xxxxxxxxxxxxxxx

It won't be applied otherwise.

Ok, thanks for the hint!

Niko