Re: [PATCH 1/2] sparc: move MSI related definitions to where they are used

From: Sam Ravnborg
Date: Tue Jul 24 2018 - 10:37:44 EST


Hi Thomas.

One nitpick below.
But other than that this is a nice cleanup:
Acked-by: Sam Ravnborg <sam@xxxxxxxxxxxx>
> +/*
> + * Locations of MSI Registers.
> + */

The SPARC way to format comments follows netdev style.
So put it all in one line and everyone are happy:

/* Locations of MSI Registers. */

> +#define MSI_MBUS_ARBEN 0xe0001008 /* MBus Arbiter Enable register */
> +
> +/*
> + * Useful bits in the MSI Registers.
> + */
Likewise

Sam