Re: [PATCH RESEND] kthread, tracing: Don't expose half-written comm when creating kthreads

From: Snild Dolkow
Date: Tue Jul 24 2018 - 11:02:59 EST


On 07/24/2018 04:48 PM, Steven Rostedt wrote:
> On Tue, 24 Jul 2018 10:17:37 +0200
> Snild Dolkow <snild@xxxxxxxx> wrote:
>
>> creator other
>> vsnprintf:
>> fill (not terminated)
>> count the rest read/use comm
>
> I think it would be better to state what was reading the comm. Like
>
> trace_sched_waking(p)
> memcpy(comm, p->comm, TASK_COMM_LEN)
>
> But the rest looks fine.
>
> -- Steve

Works for me. Reworded v2 coming up soon.

//Snild