Re: [PATCH 1/2] pinctrl: stm32: fix bank io port number

[Alexandre Torgue]

Hi Rob

On 07/20/2018 06:35 PM, Rob Herring wrote:
> On Mon, Jul 16, 2018 at 02:57:36PM +0200, Alexandre Torgue wrote:
> > In case the exti line is not in line with the bank number (that is the case
> > when there is an hole between two banks, for example GPIOK and then GPIOZ),
> > use "st,bank-ioport" DT property to get the right exti line.
> >
> > Signed-off-by: Amelie Delaunay <amelie.delaunay@xxxxxx>
> > Signed-off-by: Alexandre Torgue <alexandre.torgue@xxxxxx>
> >
> > diff --git a/Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.txt b/Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.txt
> > index 9a06e1f..60c678a 100644
> > --- a/Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.txt
> > +++ b/Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.txt
> > @@ -55,6 +55,8 @@ Optional properties:
> >      NOTE: If "gpio-ranges" is used for a gpio controller, all gpio-controller
> >      have to use a "gpio-ranges" entry.
> >      More details in Documentation/devicetree/bindings/gpio/gpio.txt.
> > + - st,bank-ioport: should correspond to the EXTI IOport selection (EXTI line
> > +   used to select GPIOs as interrupts).
>
> ioport sounds like something else. Perhaps '-exti-line'?

IOport is actually what is described in our datasheet. I could change it 
to -exti-line but I would prefer to match with the datasheet.

Regards
Alex
> >   
> >   Example 1:
> >   #include <dt-bindings/pinctrl/stm32f429-pinfunc.h>