Re: [RESEND PATCH 4/4] sh: remove board_time_init() callback
From: Arnd Bergmann
Date: Tue Jul 24 2018 - 17:33:41 EST
On Tue, Jul 24, 2018 at 7:07 PM, kbuild test robot <lkp@xxxxxxxxx> wrote:
> Hi Arnd,
>
> I love your patch! Yet something to improve:
>
> [auto build test ERROR on sof-driver-fuweitax/master]
> [also build test ERROR on v4.18-rc6 next-20180724]
> [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
>
> url: https://github.com/0day-ci/linux/commits/Baolin-Wang/sh-dreamcast-rtc-push-down-rtc-class-ops-into-driver/20180719-041209
> base: https://github.com/fuweitax/linux master
> config: sh-rsk7264_defconfig (attached as .config)
> compiler: sh4-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0
> reproduce:
> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> chmod +x ~/bin/make.cross
> # save the attached .config to linux build tree
> GCC_VERSION=7.2.0 make.cross ARCH=sh
>
> All errors (new ones prefixed by >>):
>
> arch/sh/kernel/time.c: In function 'time_init':
>>> arch/sh/kernel/time.c:42:2: error: implicit declaration of function 'timer_init'; did you mean 'time_init'? [-Werror=implicit-function-declaration]
> timer_init();
> ^~~~~~~~~~
Hmm, I fixed it locally, but Baolin forwarded the version from the
original submission that had the same bug (timer_init instead of timer_probe):
https://www.spinics.net/lists/linux-sh/msg52798.html
I'll just send the correct version once more.
Arnd