Re: [PATCH] drivers: net: wlcore: remove duplicate \n for some warnings

From: Kalle Valo
Date: Wed Jul 25 2018 - 04:40:38 EST


"H. Nikolaus Schaller" <hns@xxxxxxxxxxxxx> writes:

>> Am 25.07.2018 um 08:40 schrieb Kalle Valo <kvalo@xxxxxxxxxxxxxx>:
>>
>> "H. Nikolaus Schaller" <hns@xxxxxxxxxxxxx> writes:
>>
>>> wl1271_warning() already appends a \n to the format,
>>> so adding one to the warning string gives empty lines in the log.
>>>
>>> Signed-off-by: H. Nikolaus Schaller <hns@xxxxxxxxxxxxx>
>>
>> "drivers: net:" in the title is unnecessary, but I can remove that.
>
> Ok, thanks! I wasn't aware of the precise subsystem tagging style here.

Yeah, subsystems can do it a bit differently. But you can easily check
with git log the preferred style:

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#subject

--
Kalle Valo