Re: [PATCH v4 04/35] mtd: rawnand: denali: convert to nand_scan()

[Masahiro Yamada]

2018-07-25 21:47 GMT+09:00 Miquel Raynal <miquel.raynal@xxxxxxxxxxx>:
> Hi Boris,
>
> Boris Brezillon <boris.brezillon@xxxxxxxxxxx> wrote on Wed, 25 Jul 2018
> 11:51:16 +0200:
>
>> On Wed, 25 Jul 2018 18:42:44 +0900
>> Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx> wrote:
>>
>> >
>> > You need to remove kfree(denali->buf)
>> > from denali_remove(), right?
>>
>> Absolutely.
>>
>> >
>> > void denali_remove(struct denali_nand_info *denali)
>> > {
>> >         struct mtd_info *mtd = nand_to_mtd(&denali->nand);
>> >
>> >         nand_release(mtd);
>> >         kfree(denali->buf);       <---- REMOVE !!
>> >         denali_disable_irq(denali);
>> > }
>> >
>> >
>> > Otherwise, denali_remove() will free denali->buf twice
>> > because kfree(denali->buf) is called from denali_detach_chip().
>>
>
> Absolutely, thanks for reviewing!
>
> I'll apply with this changed.
>
> MiquÃl


Assuming you will fix this,

Acked-by: Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx>


-- 
Best Regards
Masahiro Yamada