Re: [PATCH] net: sched: cls_api: fix dead code in switch

From: Jiri Pirko
Date: Wed Jul 25 2018 - 10:33:53 EST


Wed, Jul 25, 2018 at 04:07:24PM CEST, gustavo@xxxxxxxxxxxxxx wrote:
>Code at line 1850 is unreachable. Fix this by removing the break
>statement above it, so the code for case RTM_GETCHAIN can be
>properly executed.
>
>Addresses-Coverity-ID: 1472050 ("Structurally dead code")
>Fixes: 32a4f5ecd738 ("net: sched: introduce chain object to uapi")
>Signed-off-by: Gustavo A. R. Silva <gustavo@xxxxxxxxxxxxxx>

Acked-by: Jiri Pirko <jiri@xxxxxxxxxxxx>

I'm just writing a selftest to test this path. Thanks.