RE: [PATCH net-next] tipc: add missing dev_put() on error in tipc_enable_l2_media

[Jon Maloy]

Acked
///Jon Maloy

> -----Original Message-----
> From: netdev-owner@xxxxxxxxxxxxxxx <netdev-owner@xxxxxxxxxxxxxxx> On Behalf Of YueHaibing
> Sent: Wednesday, 25 July, 2018 05:01
> To: davem@xxxxxxxxxxxxx; Jon Maloy <jon.maloy@xxxxxxxxxxxx>; ying.xue@xxxxxxxxxxxxx
> Cc: linux-kernel@xxxxxxxxxxxxxxx; netdev@xxxxxxxxxxxxxxx; tipc-discussion@xxxxxxxxxxxxxxxxxxxxx; YueHaibing
> <yuehaibing@xxxxxxxxxx>
> Subject: [PATCH net-next] tipc: add missing dev_put() on error in tipc_enable_l2_media
> 
> when tipc_own_id failed to obtain node identity,dev_put should
> be call before return -EINVAL.
> 
> Fixes: 682cd3cf946b ("tipc: confgiure and apply UDP bearer MTU on running links")
> Signed-off-by: YueHaibing <yuehaibing@xxxxxxxxxx>
> ---
>  net/tipc/bearer.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/net/tipc/bearer.c b/net/tipc/bearer.c
> index fd6d8f1..418f03d 100644
> --- a/net/tipc/bearer.c
> +++ b/net/tipc/bearer.c
> @@ -395,6 +395,7 @@ int tipc_enable_l2_media(struct net *net, struct tipc_bearer *b,
>  		tipc_net_init(net, node_id, 0);
>  	}
>  	if (!tipc_own_id(net)) {
> +		dev_put(dev);
>  		pr_warn("Failed to obtain node identity\n");
>  		return -EINVAL;
>  	}
> --
> 2.7.0
>