Re: [PATCH] net/rds/Kconfig: RDS should depend on IPV6

[Ka-Cheong Poon]

On 07/26/2018 06:36 AM, Santosh Shilimkar wrote:
> On 7/25/2018 3:20 PM, Anders Roxell wrote:
> > Build error, implicit declaration of function __inet6_ehashfn shows up
> > When RDS is enabled but not IPV6.
> > net/rds/connection.c: In function ârds_conn_bucketâ:
> > net/rds/connection.c:67:9: error: implicit declaration of function 
> > â__inet6_ehashfnâ; did you mean â__inet_ehashfnâ? 
> > [-Werror=implicit-function-declaration]
> > ÂÂ hash = __inet6_ehashfn(lhash, 0, fhash, 0, rds_hash_secret);
> > ÂÂÂÂÂÂÂÂÂ ^~~~~~~~~~~~~~~
> > ÂÂÂÂÂÂÂÂÂ __inet_ehashfn
> >
> > Current code adds IPV6 as a depends on in config RDS.
> >
> > Fixes: eee2fa6ab322 ("rds: Changing IP address internal representation 
> > to struct in6_addr")
> > Signed-off-by: Anders Roxell <anders.roxell@xxxxxxxxxx>
> > ---
> > Â net/rds/Kconfig | 2 +-
> > Â 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/net/rds/Kconfig b/net/rds/Kconfig
> > index 41f75563b54b..607128f10bcd 100644
> > --- a/net/rds/Kconfig
> > +++ b/net/rds/Kconfig
> > @@ -1,7 +1,7 @@
> > Â config RDS
> > ÂÂÂÂÂ tristate "The RDS Protocol"
> > -ÂÂÂ depends on INET
> > +ÂÂÂ depends on INET && CONFIG_IPV6
> This should build without CONFIG_IPV6 too.
>
> Hi Ka-cheong,
> Can you please loot at it ? I know you modified
> lookup function to take always in6_addr now, but
> probably hashing with '__inet_ehashfn' should
> work too for non IPV6 address(s).


I guess for now, let's add this dependency first.  I
will do a follow up patch to remove this dependency.

Thanks.


--
K. Poon
ka-cheong.poon@xxxxxxxxxx