Re: [PATCH] net/rds/Kconfig: RDS should depend on IPV6

From: David Miller
Date: Thu Jul 26 2018 - 01:34:32 EST


From: Anders Roxell <anders.roxell@xxxxxxxxxx>
Date: Thu, 26 Jul 2018 00:20:08 +0200

> Build error, implicit declaration of function __inet6_ehashfn shows up
> When RDS is enabled but not IPV6.
> net/rds/connection.c: In function ʽrds_conn_bucketʼ:
> net/rds/connection.c:67:9: error: implicit declaration of function ʽ__inet6_ehashfnʼ; did you mean ʽ__inet_ehashfnʼ? [-Werror=implicit-function-declaration]
> hash = __inet6_ehashfn(lhash, 0, fhash, 0, rds_hash_secret);
> ^~~~~~~~~~~~~~~
> __inet_ehashfn
>
> Current code adds IPV6 as a depends on in config RDS.
>
> Fixes: eee2fa6ab322 ("rds: Changing IP address internal representation to struct in6_addr")
> Signed-off-by: Anders Roxell <anders.roxell@xxxxxxxxxx>

Applied.