Re: [PATCH 1/3] mm: make memmap_init a proper function

From: Oscar Salvador
Date: Thu Jul 26 2018 - 03:50:44 EST


On Tue, Jul 24, 2018 at 07:55:18PM -0400, Pavel Tatashin wrote:
> memmap_init is sometimes a macro sometimes a function based on
> __HAVE_ARCH_MEMMAP_INIT. It is only a function on ia64. Make
> memmap_init a weak function instead, and let ia64 redefine it.
>
> Signed-off-by: Pavel Tatashin <pasha.tatashin@xxxxxxxxxx>

Looks good, and it is easier to read.

Reviewed-by: Oscar Salvador <osalvador@xxxxxxx>

Thanks
--
Oscar Salvador
SUSE L3