Re: [PATCH v3 2/5] mm: access zone->node via zone_to_nid() and zone_set_nid()

From: Oscar Salvador
Date: Thu Jul 26 2018 - 04:12:20 EST


On Thu, Jul 26, 2018 at 10:05:00AM +0200, Michal Hocko wrote:
> On Thu 26-07-18 00:01:41, osalvador@xxxxxxxxxxxxxxxxxx wrote:
> > From: Pavel Tatashin <pasha.tatashin@xxxxxxxxxx>
> >
> > zone->node is configured only when CONFIG_NUMA=y, so it is a good idea to
> > have inline functions to access this field in order to avoid ifdef's in
> > c files.
> >
> > Signed-off-by: Pavel Tatashin <pasha.tatashin@xxxxxxxxxx>
> > Signed-off-by: Oscar Salvador <osalvador@xxxxxxx>
> > Reviewed-by: Oscar Salvador <osalvador@xxxxxxx>
>
> My previous [1] question is not addressed in the changelog but I will
> not insist. If there is any reason to resubmit this then please
> consider.

Oh, sorry, I missed that.
If I resubmit a new version, I can include the information about
opengrok, although it would be better if Pavel comments on it,
as I have no clue about the software.

If not, maybe Andrew can grab it?

Thanks
--
Oscar Salvador
SUSE L3