Re: [PATCH] 9p: fix NULL pointer dereferences

From: Dmitry Vyukov
Date: Thu Jul 26 2018 - 05:28:22 EST


On Thu, Jul 26, 2018 at 10:17 AM, Dominique Martinet
<asmadeus@xxxxxxxxxxxxx> wrote:
> Tomas Bortoli wrote on Thu, Jul 26, 2018:
>> In p9_fd_create_tcp() and p9_fd_create_unix() it is possible to get
>> a NULL value in the addr parameter. Return -EINVAL in such cases.
>
> Let's refuse that at much higher level, like v9fs_mount() in
> fs/9p/vfs_super.c
>
> I can't think of any valid reason for dev_name to be NULL, it's the
> target IP or virtio handle.

But I think trans=fd allows NULL addr today, no?