Re: [PATCH v3 5/5] mm/page_alloc: Introduce memhotplug version of free_area_init_core

[Oscar Salvador]

On Thu, Jul 26, 2018 at 12:01:44AM +0200, osalvador@xxxxxxxxxxxxxxxxxx wrote:
> -	 */
> +         * When memory is hot-added, all the memory is in offline state. So
> +         * clear all zones' present_pages because they will be updated in
> +         * online_pages() and offline_pages().
> +         */

Sigh..., I should have run checkpatch. Tabs are missing there


> +void __paginginit free_area_init_core_hotplug(int nid)
> +{
> +	enum zone_type j;
> +	pg_data_t *pgdat = NODE_DATA(nid);
> +
> +	pgdat_init_internals(pgdat);
> +	for(j = 0; j < MAX_NR_ZONES; j++) {

And missing a space here.

Sorry, I will fix all this up in the next re-submission once I got feedback. 

Thanks
-- 
Oscar Salvador
SUSE L3