Re: [PATCH 2/5] rhashtable: don't hold lock on first table throughout insertion.

From: NeilBrown
Date: Thu Jul 26 2018 - 21:04:55 EST


On Wed, Jul 25 2018, Paul E. McKenney wrote:
>>
>> Looks good ... except ... naming is hard.
>>
>> is_after_call_rcu_init() asserts where in the lifecycle we are,
>> is_after_call_rcu() tests where in the lifecycle we are.
>>
>> The names are similar but the purpose is quite different.
>> Maybe s/is_after_call_rcu_init/call_rcu_init/ ??
>
> How about rcu_head_init() and rcu_head_after_call_rcu()?

Yes, I like those.
Thanks,
NeilBrown

Attachment: signature.asc
Description: PGP signature