Re: [PATCH v3 1/2] leds: core: Introduce generic pattern interface

From: Pavel Machek
Date: Fri Jul 27 2018 - 04:36:13 EST


> > This should be a bit better. I attempted to compile it with your
> > driver, but whether it works is an open question.
> Sorry for late reply. I've compiled and tested this version on my
> platform, the hardware pattern can work with one small fix as below.
> if (led_cdev->pattern_set && !led_cdev->pattern_set(led_cdev,
> data->steps, data->nsteps)) {
> return;
> }
> But I saw there are lots coding style issues and something can be
> improved in this patch, so will you send out one clean patch (I will
> help to test the hardware pattern support)? Or I can help to improve
> this code and try to upstream it again?

If you could do the upstreaming, that would be great.

I tried to get hardware accelerated LED to work on N900, but that
hardware is rather complex, so it would take me some time...

Best regards,

(cesky, pictures)

Attachment: signature.asc
Description: Digital signature