Re: [REPOST PATCH 1/4] usb: dwc2: Turn on uframe_sched on "bcm" platforms

[Minas Harutyunyan]

On 7/27/2018 12:08 AM, Douglas Anderson wrote:
> There's no reason to have the uframe scheduler off on dwc2.  Running
> with uframe_sched = False is equivalent to saying "I don't want to run
> the correct code, I want to run the old and incorrect code".
> 
> The uframe scheduler has been off on Broadcom since commit
> 58b179dcf28c ("staging: dwc2: disable uframe_sched on the bcm2835").
> Since then there have been many many improvements, notably the commit
> 9f9f09b048f5 ("usb: dwc2: host: Totally redo the microframe
> scheduler")
> 
> Presumably if everyone is good w/ the uframe_sched turned back on we
> can kill all the old and crufty non-uframe sched code.
> 
> Signed-off-by: Douglas Anderson <dianders@xxxxxxxxxxxx>
> Tested-by: Stefan Wahren <stefan.wahren@xxxxxxxx>
Acked-by: Minas Harutyunyan <hminas@xxxxxxxxxxxx>

> ---
> 
>   drivers/usb/dwc2/params.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/usb/dwc2/params.c b/drivers/usb/dwc2/params.c
> index af075d4da895..14b8742e62fa 100644
> --- a/drivers/usb/dwc2/params.c
> +++ b/drivers/usb/dwc2/params.c
> @@ -47,7 +47,6 @@ static void dwc2_set_bcm_params(struct dwc2_hsotg *hsotg)
>   	p->max_transfer_size = 65535;
>   	p->max_packet_count = 511;
>   	p->ahbcfg = 0x10;
> -	p->uframe_sched = false;
>   }
>   
>   static void dwc2_set_his_params(struct dwc2_hsotg *hsotg)
>