Re: [PATCHv5 18/19] x86/mm: Handle encrypted memory in page_to_virt() and __pa()

From: Kirill A. Shutemov
Date: Fri Jul 27 2018 - 09:49:48 EST


On Thu, Jul 26, 2018 at 10:26:23AM -0700, Dave Hansen wrote:
> On 07/23/2018 03:12 AM, Kirill A. Shutemov wrote:
> > page_to_virt() definition overwrites default macros provided by
> > <linux/mm.h>. We only overwrite the macros if MTKME is enabled
> > compile-time.
>
> Can you remind me why we need this in page_to_virt() as opposed to in
> the kmap() code? Is it because we have lots of 64-bit code that doesn't
> use kmap() or something?

I just found it most suitable. It should cover all cases, even if kmap()
is not used.

--
Kirill A. Shutemov