Re: [PATCH v6 5/6] Uprobes/sdt: Prevent multiple reference counter for same uprobe
From: Oleg Nesterov
Date: Fri Jul 27 2018 - 09:55:36 EST
On 07/27, Ravi Bangoria wrote:
> > I simply can't understand this "bool installed"....
> That boolean is needed because consumer_filter() returns false when this
> function gets called first time from uprobe_register().
Ah yes, I forgot about the (ugly) 2-stage TRACE_REG_PERF_REGISTER +
But then I think the whole idea of REF_CTR_OFF_RELOADED is even more broken.
> I have a solution for this. Idea is, if reference counter is reloaded, save
> of all mms for which consumer_filter() denied to updated when being called
> from register_for_each_vma(). Use this list of mms as checklist next time
> onwards. I don't know if it's good to do that or not.
Sounds horrible ;) and I bet this is not enough.
> Please let me know if you have any better approach.
Just drop this patch.
If we can't make it per consumer, let it be global like it was in first version.