Re: [PATCH v3.1 10/10] arm64: dts: allwinner: a64: Enable HDMI output on A64 boards w/ HDMI

From: Icenowy Zheng
Date: Fri Jul 27 2018 - 11:42:12 EST

å 2018-07-27 22:00ïMaxime Ripard åéï
On Fri, Jul 27, 2018 at 09:26:11PM +0800, Icenowy Zheng wrote:


ä 2018å7æ27æ GMT+08:00 äå8:56:15, Maxime Ripard <maxime.ripard@xxxxxxxxxxx> åå:
>On Fri, Jul 27, 2018 at 01:12:57AM +0800, Icenowy Zheng wrote:
>> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-pine64.dts
>b/arch/arm64/boot/dts/allwinner/sun50i-a64-pine64.dts
>> index 1b9b92e541d2..1b972bade9f6 100644
>> --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-pine64.dts
>> +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-pine64.dts
>> @@ -62,6 +62,21 @@
>> chosen {
>> stdout-path = "serial0:115200n8";
>> };
>> +
>> + connector {
>> + compatible = "hdmi-connector";
>> + type = "a";
>> +
>> + port {
>> + hdmi_con_in: endpoint {
>> + remote-endpoint = <&hdmi_out_con>;
>> + };
>> + };
>> + };
>> +};
>> +
>> +&de {
>> + status = "okay";
>> };
>>
>> &ehci0 {
>> @@ -82,6 +97,17 @@
>>
>> };
>>
>> +&hdmi {
>> + hdmi-supply = <&reg_dldo1>;
>> + status = "okay";
>> +};
>> +
>> +&hdmi_out {
>> + hdmi_out_con: endpoint {
>> + remote-endpoint = <&hdmi_con_in>;
>> + };
>> +};
>> +
>> &i2c1 {
>> pinctrl-names = "default";
>> pinctrl-0 = <&i2c1_pins>;
>> @@ -99,6 +125,10 @@
>> };
>> };
>>
>> +&mixer1 {
>> + status = "okay";
>> +};
>> +
>> &mmc0 {
>> pinctrl-names = "default";
>> pinctrl-0 = <&mmc0_pins>;
>> @@ -238,6 +268,10 @@
>> status = "disabled";
>> };
>>
>> +&tcon1 {
>> + status = "okay";
>> +};
>
>Is it working or not on the pine64?

Not tested yet, as my main A64 device is Pine A64-LTS now.

It was last reported as broken, so it's better to leave it out of that
patch until someone figures it out.

Sorry, I did find a bug. Although after fixing it HDMI on Pine A64+
works fine.

Will fix the bug when sending v3.2 (resending after rc1).


Thanks!
Maxime