Re: [PATCH net-next] net: ethernet: ti: cpsw: replace unnecessarily macroses on functions

From: Ivan Khoronzhuk
Date: Fri Jul 27 2018 - 16:49:59 EST


On Fri, Jul 27, 2018 at 10:32:03PM +0200, Andrew Lunn wrote:
+static inline void cpsw_src_port_detect(struct cpsw_common *cpsw, int status,
+ struct sk_buff *skb)

Please don't use inline. Let the compiler decide.

Andrew

Corrected in v2

--
Regards,
Ivan Khoronzhuk