Re: [PATCH v2 net-next] net: ethernet: ti: cpsw: replace unnecessarily macroses on functions

From: Andrew Lunn
Date: Fri Jul 27 2018 - 17:09:23 EST


On Fri, Jul 27, 2018 at 11:49:58PM +0300, Ivan Khoronzhuk wrote:
> Replace ugly macroses on functions.
>
> v2..v1:
> - removed inline for cpsw_src_port_detect()

Hi Ivan

Comments like this should be placed under the ---. Otherwise the
appear in the commit message.

Andrew