Re: [PATCH 30/38] vfs: syscall: Add fsmount() to create a mount for a superblock [ver #10]

From: David Howells
Date: Fri Jul 27 2018 - 18:09:45 EST


Andy Lutomirski <luto@xxxxxxxxxxxxxx> wrote:

> int mfd = fsmount(...);
>
> where you pass in an fscontext fd and get out an fd referring to the
> root of the filesystem? In this case, maybe fs_open_root(2) would be
> a better name.

It's not necessarily the root of the filesystem in the sense of sb->s_root.
It might be a subset of that, or it might be a part of a filesystem that might
have multiple roots because it doesn't know where the real root is (NFS2, for
example).

> This *definitely* needs to be clearer in the description.

I'm open to suggestions of better wording. It's a bit hard to explain
because, as you pointed out, the terminology is overloaded.

David