Re: [TRIVIAL RFC PATCH] Kconfigs - reduce use of "depends on EXPERT"

[Michael BÃsch]

On Sun, 29 Jul 2018 11:16:37 -0700
Joe Perches <joe@xxxxxxxxxxx> wrote:

> (removing a bunch of cc's)
> 
> On Sun, 2018-07-29 at 13:42 +0200, Michael BÃsch wrote:
> > On Sat, 28 Jul 2018 15:13:00 -0700
> > Joe Perches <joe@xxxxxxxxxxx> wrote:
> >   
> > >  config SSB_SILENT
> > > -	bool "No SSB kernel messages"
> > > -	depends on SSB && EXPERT
> > > +	bool "No SSB kernel messages" if EXPERT
> > > +	depends on SSB
> > >  	help
> > >  	  This option turns off all Sonics Silicon Backplane printks.
> > >  	  Note that you won't be able to identify problems, once  
> > 
> > 
> > What about removing this option entirely?
> > We would just have to remove it from Kconfig and from its only use in
> > drivers/ssb/ssb_private.h
> > I don't think anybody uses (or should use) this option anyway.
> > That would reduce the EXPERT dependencies by one, which is a good
> > thing. :)  
> 
> I'm fine with that, but it was originally your code from
> the first ssb commit in 2007:
> 
> 	This might only be desired for production kernels on
> 	embedded devices to reduce the kernel size.
> 
> Presumably for ddwrt and such.

Yeah, but it doesn't make sense to do this in ssb only.
And it only saves a couple of k at best.

> Removal could simplify the ssb_<foo> printk logic a bit too.
> 
> Perhaps something like the below,
> but your code, your decisions...:


This is great!
Thanks.

Reviewed-by: Michael Buesch <m@xxxxxxx>


-- 
Michael

Attachment: pgp7H42BkrrjP.pgp
Description: OpenPGP digital signature