Re: [PATCH] pinctrl/amd: fix gpio irq level in debugfs

[Linus Walleij]

On Tue, Jul 17, 2018 at 3:07 AM Daniel Kurtz <djkurtz@xxxxxxxxxxxx> wrote:

> According to the AMD BKDG, the GPIO ActiveLevel bits (10:9) map to:
>  00 Active High
>  01 Active Low
>  10 Active on both edges iff LevelTrig (bit 8) == 0
>  11 Reserved
>
> The current code has a bug where it interprets 00 => Active Low, and
> 01 => Active High.
>
> Fix the bug, restrict "Active on both" to just the edge trigger case, and
> refactor a bit to make the logic more readable.
>
> Change-Id: Id7775ae4cb61d193fa7fbb83967a8c5a7cdd0de6

I stripped that off.

> Signed-off-by: Daniel Kurtz <djkurtz@xxxxxxxxxxxx>

Patch applied!

Thanks for your fixing and attention to detail!

Yours,
Linus Walleij