Re: [PATCH] gpio: tegra: Fix tegra_gpio_irq_set_type()

From: Linus Walleij
Date: Sun Jul 29 2018 - 16:39:44 EST


On Tue, Jul 17, 2018 at 6:12 PM Dmitry Osipenko <digetx@xxxxxxxxx> wrote:

> Commit 36b312792b97 ("gpiolib: Respect error code of ->get_direction()")
> broke tegra_gpio_irq_set_type() because requesting of GPIO direction must
> be done after enabling GPIO function for a pin.
>
> This patch fixes drivers probe failure like this:
>
> gpio gpiochip0: (tegra-gpio): gpiochip_lock_as_irq: cannot get GPIO direction
> tegra-gpio 6000d000.gpio: unable to lock Tegra GPIO 144 as IRQ
>
> Fixes: 36b312792b97 ("gpiolib: Respect error code of ->get_direction()")
> Signed-off-by: Dmitry Osipenko <digetx@xxxxxxxxx>

Patch applied with Jon's tags.

Yours,
Linus Walleij