Re: [PATCH] gpio: ml-ioh: Fix buffer underwrite on probe error path

[Linus Walleij]

On Mon, Jul 23, 2018 at 6:54 PM Anton Vasilyev <vasilyev@xxxxxxxxx> wrote:

> If ioh_gpio_probe() fails on devm_irq_alloc_descs() then chip may point
> to any element of chip_save array, so reverse iteration from pointer chip
> may become chip_save[-1] and gpiochip_remove() will operate with wrong
> memory.
>
> The patch fix the error path of ioh_gpio_probe() to correctly bypass
> chip_save array.
>
> Found by Linux Driver Verification project (linuxtesting.org).
>
> Signed-off-by: Anton Vasilyev <vasilyev@xxxxxxxxx>

Patch applied, nice work!

Yours,
Linus Walleij