Re: [PATCH] pinctrl: mediatek: include chained_irq.h header

From: Linus Walleij
Date: Sun Jul 29 2018 - 17:16:09 EST


On Tue, Jul 24, 2018 at 1:57 PM Arnd Bergmann <arnd@xxxxxxxx> wrote:

> Some randconfig builds fail in the mtk-eint driver:
>
> drivers/pinctrl/mediatek/mtk-eint.c: In function 'mtk_eint_irq_handler':
> drivers/pinctrl/mediatek/mtk-eint.c:324:2: error: implicit declaration of function 'chained_irq_enter'; did you mean 'rcu_irq_enter'? [-Werror=implicit-function-declaration]
> chained_irq_enter(chip, desc);
> ^~~~~~~~~~~~~~~~~
> rcu_irq_enter
> drivers/pinctrl/mediatek/mtk-eint.c:367:2: error: implicit declaration of function 'chained_irq_exit'; did you mean 'rcu_irq_exit'? [-Werror=implicit-function-declaration]
>
> The functions are declared in linux/irqchip/chained_irq.h, and including
> that header makes it build in all configurations.
>
> Fixes: e46df235b4e6 ("pinctrl: mediatek: refactor EINT related code for all MediaTek pinctrl can fit")
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>

Patch applied!

Thanks Arnd!

Yours,
Linus Walleij