Re: [Xen-devel] [PATCH] xen-netfront: wait xenbus state change when load module manually

From: Xiao Liang
Date: Mon Jul 30 2018 - 04:18:19 EST


Thanks, David

On 07/29/2018 11:30 PM, David Miller wrote:
From: Xiao Liang <xiliang@xxxxxxxxxx>
Date: Fri, 27 Jul 2018 17:56:08 +0800

@@ -1330,6 +1331,11 @@ static struct net_device *xennet_create_dev(struct xenbus_device *dev)
netif_carrier_off(netdev);
xenbus_switch_state(dev, XenbusStateInitialising);
+ wait_event(module_load_q,
+ xenbus_read_driver_state(dev->otherend) !=
+ XenbusStateClosed &&
+ xenbus_read_driver_state(dev->otherend) !=
+ XenbusStateUnknown);
return netdev;
exit:
What performs the wakeups that will trigger for this sleep site?
In my understanding, backend leaving closed/unknow state can trigger the wakeups. I mean to make sure both sides are ready for creating connection.

Thanks,
Liang

Thank you.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel