Re: [PATCH v3 1/7] mm, slab: combine kmalloc_caches and kmalloc_dma_caches

From: Christopher Lameter
Date: Mon Jul 30 2018 - 11:38:57 EST


On Wed, 18 Jul 2018, Vlastimil Babka wrote:

> --- a/include/linux/slab.h
> +++ b/include/linux/slab.h
> @@ -295,12 +295,28 @@ static inline void __check_heap_object(const void *ptr, unsigned long n,
> #define SLAB_OBJ_MIN_SIZE (KMALLOC_MIN_SIZE < 16 ? \
> (KMALLOC_MIN_SIZE) : 16)
>
> +#define KMALLOC_NORMAL 0
> +#ifdef CONFIG_ZONE_DMA
> +#define KMALLOC_DMA 1
> +#define KMALLOC_TYPES 2
> +#else
> +#define KMALLOC_TYPES 1
> +#endif

An emum would be better here I think.

But the patch is ok

Acked-by: Christoph Lameter <cl@xxxxxxxxx>