Re: [PATCH net-next 1/2] tcp: call tcp_drop() in tcp collapse

[Eric Dumazet]

On Sun, Jul 29, 2018 at 10:40 PM Yafang Shao <laoar.shao@xxxxxxxxx> wrote:

> Should we put NET_INC_STATS(sock_net(sk),  mib_idx) into the funtion
> tcp_drop() ?
> Then we could easily relate the sk_drops with the SNMP counters.
>
> Something like that,
>
>     static void tcp_drop(struct sock *sk, struct sk_buff *skb, int mib_idx)
>     {
>         int segs = max_t(u16, 1, skb_shinfo(skb)->gso_segs);
>
>         atomic_add(segs, &sk->sk_drops);
>         NET_ADD_STATS(sock_net(sk), mib_idx, segs);
>         __kfree_skb(skb);
>     }

We had a discussion during netconf, and Brendan Gregg was working on
an idea like that,
so that distinct events could be traced/reported.

I prefer letting Brendan submit his patch, which not only refactors
things, but add new functionality.

Thanks.