Re: [PATCH] stop_machine: Disable preemption after queueing stopper threads

From: Thomas Gleixner
Date: Mon Jul 30 2018 - 13:16:18 EST


On Mon, 30 Jul 2018, Sodagudi Prasad wrote:
> How about including below change as well? Currently, there is no way to

That would be a completely separate change.

> identify thread migrations completed or not. When we observe this issue, the
> symptom was work queue lock up. It is better to have some timeout here and
> induce the bug_on.

BUG_ON() is wrong. Why kill the thing if there is at least a theoretical
chance that stuff can continue half baken so you can get more info out of
it. The back trace is pretty much uninteresting.

Thanks,

tglx