Re: [PATCH] PCI: call dma_debug_add_bus for pci_bus_type in common code
From: Joerg Roedel
Date: Tue Jul 31 2018 - 03:36:06 EST
On Mon, Jul 30, 2018 at 04:17:13PM -0500, Bjorn Helgaas wrote:
> [+cc Joerg]
>
> On Mon, Jul 30, 2018 at 09:38:42AM +0200, Christoph Hellwig wrote:
> > There is nothing arch specific about PCI or dma-debug, so move this
> > call to common code just after registering the bus type.
>
> I assume that previously, even if the user set CONFIG_DMA_API_DEBUG=y
> we only got PCI DMA debug on powerpc, sh, and x86. And after this
> patch, we'll get PCI DMA debug on *all* arches?
>
> If that's true, I'll add a comment to that effect to the commitlog
> since that new functionality might be of interest to other arches.
There should be implicit support for dma-debug for all arches that use
the generic dma_ops code. The dma_debug_add_bus() function just adds the
reporting of pending dma-allocations on driver-unload for a device.
Regards,
Joerg