Re: [PATCH] media: omap2: omapfb: fix bugon.cocci warnings

From: Bartlomiej Zolnierkiewicz
Date: Tue Jul 31 2018 - 07:04:20 EST


On Thursday, July 26, 2018 01:57:00 AM kbuild test robot wrote:
> From: kbuild test robot <fengguang.wu@xxxxxxxxx>
>
> drivers/video/fbdev/omap2/omapfb/dss/dss_features.c:895:2-5: WARNING: Use BUG_ON instead of if condition followed by BUG.
> Please make sure the condition has no side effects (see conditional BUG_ON definition in include/asm-generic/bug.h)
>
> Use BUG_ON instead of a if condition followed by BUG.
>
> Semantic patch information:
> This makes an effort to find cases where BUG() follows an if
> condition on an expression and replaces the if condition and BUG()
> with a BUG_ON having the conditional expression of the if statement
> as argument.
>
> Generated by: scripts/coccinelle/misc/bugon.cocci
>
> Fixes: 7378f1149884 ("media: omap2: omapfb: allow building it with COMPILE_TEST")
> Signed-off-by: kbuild test robot <fengguang.wu@xxxxxxxxx>

Patch queued for 4.19 (w/ "media"->"fbdev" fixup in the patch title), thanks.

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics