Re: [PATCH v2] tracefs: Annotate tracefs_ops with __ro_after_init
From: Steven Rostedt
Date: Tue Jul 31 2018 - 11:31:58 EST
On Mon, 30 Jul 2018 17:25:06 -0700
Kees Cook <keescook@xxxxxxxxxxxx> wrote:
> On Wed, Jul 25, 2018 at 11:00 AM, Kees Cook <keescook@xxxxxxxxxxxx> wrote:
> > On Wed, Jul 25, 2018 at 10:19 AM, Zubin Mithra <zsm@xxxxxxxxxxxx> wrote:
> >> tracefs_ops is initialized inside tracefs_create_instance_dir and not
> >> modified after. tracefs_create_instance_dir allows for initialization
> >> only once, and is called from create_trace_instances(marked __init),
> >> which is called from tracer_init_tracefs(marked __init). Also, mark
> >> tracefs_create_instance_dir as __init.
> >>
> >> Signed-off-by: Zubin Mithra <zsm@xxxxxxxxxxxx>
> >
> > Reviewed-by: Kees Cook <keescook@xxxxxxxxxxxx>
>
> Steve, do you have a tree for this or should we rope akpm in? :)
>
I'll pull it in. I'm currently working on a bunch of small patches for
the merge window now anyway.
Thanks!
-- Steve