Re: [BUG BISECT] Ethernet fail on VF50 (OF: Don't set default coherent DMA mask)

[Robin Murphy]

On 31/07/18 16:43, Guenter Roeck wrote:
> On Tue, Jul 31, 2018 at 03:09:34PM +0100, Robin Murphy wrote:
> > > Please note that sparc images still generate the warning (next-20180731).
> >
> > Ugh, OK, any ideas what sparc does to create these platform devices that
> > isn't of_platform_device_create_pdata() and has somehow grown an implicit
> > dependency on of_dma_configure() since 4.12? I'm looking, but nothing jumps
> > out...
>
> I suspect it might be of_device_register(), called from
> 	arch/sparc/kernel/of_device_64.c:scan_one_device()
> 	arch/sparc/kernel/of_device_32.c:scan_one_device()

Right, that's as far as I got as well, so I'm struggling to see how 
these things ever got DMA masks set before the of_dma_configure() call 
moved out of of_platform_device_create_pdata(), or why it wasn't a 
problem prior to the generic dma_ops rework if they didn't :/

Robin.