Re: [PATCH 1/2] goldfish: Add missing includes to goldfish.h

[Roman Kiryanov]

Hi Greg,

could you please confirm you received my patch?

Regards,
Roman.
On Mon, Jul 23, 2018 at 3:47 PM <rkir@xxxxxxxxxx> wrote:
>
> From: Roman Kiryanov <rkir@xxxxxxxxxx>
>
> goldfish.h refers to external symbols such as
> dma_addr_t and writel. This causes compilation errors
> if this file is included before other header files.
>
> The mentioned symbols are defined in types.h (dma_addr_t)
> and io.h (writel).
>
> Signed-off-by: Roman Kiryanov <rkir@xxxxxxxxxx>
> ---
>  include/linux/goldfish.h | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/include/linux/goldfish.h b/include/linux/goldfish.h
> index 2835c150c3ff..159b4191f15d 100644
> --- a/include/linux/goldfish.h
> +++ b/include/linux/goldfish.h
> @@ -2,6 +2,9 @@
>  #ifndef __LINUX_GOLDFISH_H
>  #define __LINUX_GOLDFISH_H
>
> +#include <linux/types.h>
> +#include <linux/io.h>
> +
>  /* Helpers for Goldfish virtual platform */
>
>  static inline void gf_write_ptr(const void *ptr, void __iomem *portl,
> --
> 2.18.0.233.g985f88cf7e-goog
>